Repository navigation
Conversation
vicheey
approved these changes
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
Sets
UpdateReplacePolicy: Retainon the generatedAWS::Lambda::WebFunctionRevision, for bothAutoDeploymentModevalues. The endpoint, function and role are unchanged.Every revision property is create-only, so each code or configuration change replaces
<LogicalId>Revision. WithAutoDeploymentMode: Disabled, the endpoint usually still routes to the old revision throughRevisionWeights. CloudFormation's cleanup then fails to delete it ("cannot be deleted because the endpoints [prod] are using it") and retries for about 10 minutes before finishing with "One or more resources could not be deleted". WithRetain, CloudFormation skips that delete.UpdateReplacePolicyset on theAWS::Serverless::WebFunctionstill applies to every generated resource and overrides this default.Description of how you validated changes
webfunction_update_replace_policyfor the override.make format-check,make lintandmake testpass.LatestRevisionupdate: the endpoint moved to the new revision, and the old one wasDELETE_SKIPPED(37s).Disabledupdate with the endpoint pinned to the old revision:DELETE_SKIPPED, thenUPDATE_COMPLETEin 38s with no warning (previously about 10 minutes and "could not be deleted").WebFnRevisionwere restored. The revision created by the failed update was alsoDELETE_SKIPPED, becauseUpdateReplacePolicyapplies to rollback cleanup too.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.