greengrass-lite: fix 32-bit build by enabling UNITY_SUPPORT_64 - #17128
Open
gregbreen wants to merge 1 commit into
Open
greengrass-lite: fix 32-bit build by enabling UNITY_SUPPORT_64#17128gregbreen wants to merge 1 commit into
gregbreen wants to merge 1 commit into
Conversation
The bundled gg_sdk test helpers (thirdparty/gg_sdk/unity/gg_test)
reference UNITY_DISPLAY_STYLE_INT64 / UNITY_DISPLAY_STYLE_UINT64, which
Unity only defines when UNITY_SUPPORT_64 is set. Unity auto-enables that
on 64-bit targets only, so do_compile fails on 32-bit tunes such as
arm/cortexa15t2hf-neon (qemuarm) with:
error: 'UNITY_DISPLAY_STYLE_INT64' undeclared;
did you mean 'UNITY_DISPLAY_STYLE_INT32'?
Add -DUNITY_SUPPORT_64 to CFLAGS. It is arch-independent and a no-op on
64-bit builds where Unity already defines it (guarded by
#ifndef UNITY_SUPPORT_64).
This is a stopgap; the proper fix belongs upstream in
aws-greengrass-component-sdk and can be removed here once that lands in
the pinned rev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#17127
Description of changes:
Stopgap to get the Greengrass nucleus lite building until we get upstream fixes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.