Repository navigation
Bump AngleSharp to 1.8.6 - #1958
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The dependency update and generated snapshot address the reported interface mismatch, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates AngleSharp to 1.8.6 so bUnit’s generated select-element wrapper implements the newly required SelectedIndex setter, addressing the Find failure reported in #1957.
Changes:
- Bumps the central AngleSharp dependency from 1.8.5 to 1.8.6.
- Updates the generator snapshot to include the forwarding setter.
- Documents the compatibility fix in the changelog.
| File | Description |
|---|---|
| tests/bunit.generators.tests/Web.AngleSharp/WrapperElementsGeneratorTest.Generator#HtmlSelectElementWrapper.g.verified.cs | Records the generated SelectedIndex setter. |
| Directory.Packages.props | Updates AngleSharp to 1.8.6. |
| CHANGELOG.md | Documents the TypeLoadException fix. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump AngleSharp and fixes #1957