Skip to content

Send content-length header in method responses#132

Open
chfritz wants to merge 1 commit into
baalexander:masterfrom
chfritz:master
Open

Send content-length header in method responses#132
chfritz wants to merge 1 commit into
baalexander:masterfrom
chfritz:master

Conversation

@chfritz

@chfritz chfritz commented Jun 28, 2016

Copy link
Copy Markdown
  • unlike method calls (client), method responses (server) did not yet
    send content-length headers. This was causing problem with at least
    one client (ros's turtlesim, in the context of rosnodejs: publishing
    to /turtlt1/cmd_vel had no effect on the turtle). This commit fixes
    that.

Comment thread lib/server.js Outdated
- unlike method calls (client), method responses (server) did not yet
  send content-length headers. This was causing problem with at least
  one client (ros's turtlesim, in the context of rosnodejs: publishing
  to /turtlt1/cmd_vel had no effect on the turtle). This commit fixes
  that.
@atn18

atn18 commented Jun 4, 2019

Copy link
Copy Markdown

Hi, there!
Are there any stop factors for merging this PR?

@rudicus

rudicus commented Nov 18, 2019

Copy link
Copy Markdown

@agladkov We would love to see this patch pushed. Are there any actual objections?

@atn18

atn18 commented Nov 19, 2019

Copy link
Copy Markdown

I have no objections.
I have not merge perms :)
Question to @baalexander

@rudicus

rudicus commented Nov 19, 2019

Copy link
Copy Markdown

@baalexander @patricklodder Any chance you guys can merge this and update the published npm package? We are dependent on a downstream package (https://www.npmjs.com/package/rosnodejs) and I would hate to have to fork both projects for a 1 line change. Thanks.

@cr1979

cr1979 commented Mar 5, 2023

Copy link
Copy Markdown

I need that change as well!

@chfritz

chfritz commented Mar 5, 2023

Copy link
Copy Markdown
Author

@cr1979 We've forked the package a while ago and published a new one with the fixes we needed. You can find it here: https://www.npmjs.com/package/xmlrpc-rosnodejs. Just change xmlrpc to xmlrpc-rosnodejs everywhere.

@cr1979

cr1979 commented Mar 5, 2023

Copy link
Copy Markdown

@cr1979 We've forked the package a while ago and published a new one with the fixes we needed. You can find it here: https://www.npmjs.com/package/xmlrpc-rosnodejs. Just change xmlrpc to xmlrpc-rosnodejs everywhere.

@chfritz perfect thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants