Added blockmachine - #1750
Open
Danielvul wants to merge 3 commits into
Open
Conversation
Collaborator
🟡 Heimdall Review Status
|
Collaborator
|
Hi @Danielvul, thank you for the submission. Please address the following notes:
|
Author
|
@roethke all done, thanks! Re. 3, we don't support testnet at the moment. Please let me know if that's a priority for you Cheers |
roethke
self-requested a review
August 25, 2026 15:48
roethke
approved these changes
Aug 25, 2026
Collaborator
|
Review Error for roethke @ 2026-08-25 15:49:56 UTC |
roethke
self-requested a review
August 25, 2026 15:50
roethke
approved these changes
Aug 25, 2026
youssefea
approved these changes
Aug 25, 2026
Collaborator
|
Review Error for youssefea @ 2026-08-25 15:53:07 UTC |
youssefea
approved these changes
Aug 25, 2026
Collaborator
|
Hey @Danielvul, thanks for the changes. Last fix, please fix your commit to ensure that it is verified so we are able to merge. |
Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added blockmachine's base endpoint
https://blockmachine.io/base-rpc
Notes to reviewers
Also got public endpoints if there is somewhere else to list them or include in CLIs?
https://rpc-base.blockmachine.io
wss://rpc-base.blockmachine.io
How has it been tested?
N/A