added stablecoin gas demo - #79
Open
soheimam wants to merge 5 commits into
Open
Conversation
soheimam
commented
Aug 20, 2026
soheimam
commented
Contributor
- Added 8130 account creation in demo
- Added b20 stablecoin gas payment
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
montycheese
reviewed
Aug 20, 2026
montycheese
left a comment
montycheese
left a comment
Contributor
There was a problem hiding this comment.
awesome demo, really slick improvements on v1! some feedback:
during the 'create token step'
this recent activity updating in real time super slick, I think adding more context to 'configuring [token name 1/2]' could be useful for developers, especially as they'll need to implement those steps on their end
one thing that isn't immediately clear (to me as well) is what checking the batch approve+ transfer step do. Because if I leave it unchecked, it does the transfer, it doesn't request a separate approval step before. Could be useful to add more context to that
montycheese
previously approved these changes
Aug 21, 2026
Collaborator
|
Review Error for montycheese @ 2026-08-21 15:16:35 UTC |
montycheese
force-pushed
the
feat/update-demo
branch
from
August 25, 2026 19:22
a33068f to
0d08415
Compare
…s batches Two problems reported after the rebase onto main's account engine. The activity log moved into the shared bottom drawer, which is sticky and full-bleed, so it read as a separate panel rather than part of the page. B20 narrates multi-transaction flows and the log has to stay readable next to the form that started them, so it goes back to an inline card and the drawer in AccountDemoShell becomes optional. Creating a token failed at the configure step. sendBatches looped over sendActiveCalls, and signComposed re-reads the nonce and probes for code on every call. The public RPC is load-balanced across replicas whose heads can differ, so the read between two sends can answer from a replica that has not seen the first one: the second transaction is signed with the same nonce and dropped as a duplicate. sendActiveCallsBatches reads both once up front and counts each batch's sequence from there.
Creating a token from a new account failed on the second transaction with "actor is not bound" (surfaced as "Missing or invalid parameters"). An account's code and the actors bound to it reach every RPC replica a moment after the transaction that wrote them lands, so the batch prepared right behind the one that deployed the account was validated against a replica that had not seen it yet and was rejected before it was ever broadcast. Occasionally a later batch was broadcast and then dropped instead: the engine signs at a flat 1 gwei maxFeePerGas, which equals the current base fee, so the transaction carries no priority fee and is not guaranteed a slot. sendActiveCallsBatches now retries a batch on both. A rejection before broadcast waits for the state to propagate and signs again on the same nonce. A broadcast that has not been included gets a longer wait, then the node is asked whether it still holds the transaction — one it has dropped is sent again, one it still holds is left alone so a second copy cannot collide with it. The receipt-and-phase check that broadcast8130 already did moves into awaitInclusion so both paths share it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.