feat(icons): morph copy/check icon toggles with morphicons - #87
Open
montycheese wants to merge 2 commits into
Open
feat(icons): morph copy/check icon toggles with morphicons#87montycheese wants to merge 2 commits into
montycheese wants to merge 2 commits into
Conversation
Animates the clipboard-to-check transitions in CopyPromptButton, internal-explorer's CopyButton, and vibenet's CopyableValue instead of an instant swap.
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
morphiconslibrary (spring-physics SVG path morphing) and uses it to animate the three copy→check icon toggles that previously swapped instantly:CopyPromptButton(B20),CopyButton(internal-explorer), andCopyableValue(vibenet).CLIPBOARD_MORPH_ICON/CHECK_MORPH_ICONpath data toapp/components/ui/icons.tsx, reusing the app's existing icon geometry.CopyableValue's copy icon lives on a 40x40 grid; regridded onto morphicons' 24x24 baseline viafitIconso it can morph against the 24x24 check icon.Test plan
tsc --noEmitpassesnext lintpasses on changed files