You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep bare help as the help alias for activate and uninstall, while adding an explicit --project <name> selector so a project literally named help remains reachable. Reference the disambiguation behavior introduced by #2366.
This adds a --project <name> escape hatch to activate.sh/uninstall.sh, letting a project literally named help be targeted explicitly - a sound resolution to #2388. Two things worth fixing before merge:
Run-bundle labeling regression (cli/bash/commands/basectl/basectl.sh, basectl_run_bundle_project, ~line 606): this function already treats --project as a value-consuming flag to skip when scanning a subcommand's argv for the positional slug used to label the run-bundle/log directory. So basectl activate --project myproj - the exact new form this PR introduces, and the only way to reach a project named help - now produces a run bundle labeled just activate instead of activate__myproj, silently losing per-project log separation. Verified directly: --project is in basectl_run_bundle_project's option-value allowlist, so the loop skips both the flag and its value and never reaches basectl_runtime_slug.
Duplicated parsing logic instead of reuse: activate.sh already sources cli/bash/commands/basectl/subcommands/project_command_helpers.sh, which defines base_project_command_parse_args - a shared helper that already implements --project/--project=value parsing with duplicate-detection, and is already used by demo.sh/test.sh. This PR hand-rolls a second, independent ~20-line copy of the same logic in both activate.sh and uninstall.sh instead of reusing it. The two copies have already drifted: uninstall.sh reports a different, less precise error message ("The 'uninstall' command accepts at most one project name") than activate.sh ("does not accept a positional project with --project") for the identical misuse of combining --project with a positional name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep bare
helpas the help alias foractivateanduninstall, while adding an explicit--project <name>selector so a project literally namedhelpremains reachable. Reference the disambiguation behavior introduced by #2366.Validation
bash -ngit diff --checkFixes #2388
Refs #2366