Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bayes_opt/parameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ def kernel_transform(self, value: NDArray[Float]) -> NDArray[Float]:
"""
value = np.atleast_2d(value)
res = np.zeros(value.shape)
res[:, np.argmax(value, axis=1)] = 1
res[np.arange(value.shape[0]), np.argmax(value, axis=1)] = 1
return res

@property
Expand Down
13 changes: 13 additions & 0 deletions tests/test_parameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,19 @@ def target_func(**kwargs):
assert p1.kernel_transform(np.array([1.3, 3.6, 7.2])) == pytest.approx(np.array([1, 4, 7]))


def test_categorical_kernel_transform_preserves_batch_rows():
parameter = CategoricalParameter("x", ["a", "b", "c"])
values = np.array([[0.2, 0.8, 0.1], [0.9, 0.1, 0.2], [0.1, 0.2, 0.7], [0.2, 0.8, 0.1]])
expected = np.eye(3)[[1, 0, 2, 1]]
np.testing.assert_array_equal(parameter.kernel_transform(values), expected)
kernel = wrap_kernel(kernels.RBF(length_scale=1.0), parameter.kernel_transform)
np.testing.assert_allclose(kernel(values), kernels.RBF(length_scale=1.0)(expected))
np.testing.assert_allclose(
kernel(values, values[:2]), kernels.RBF(length_scale=1.0)(expected, expected[:2])
)
np.testing.assert_array_equal(parameter.kernel_transform(values[:1]), expected[:1])


def test_cat_parameters():
fruit_ratings = {"apple": 1.0, "banana": 2.0, "mango": 5.0, "honeydew melon": -10.0, "strawberry": np.pi}

Expand Down
Loading