Skip to content

Feat: adding Windows linker flag to py_extension #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karenwuz wants to merge 1 commit into from
+17 −0
Closed

Feat: adding Windows linker flag to py_extension #4317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions python/private/cc/py_extension_macro.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,23 @@ def py_extension(
"//conditions:default": ["-fPIC"],
})

linkopts = linkopts + select({
# Windows MinGW linker flags are needed for Python upb windows x86 wheels test
"//python/dist:windows_x86_32": ["-static-libgcc"],
"//conditions:default": [],
}) + select({
"//python/dist:windows_x86_64_mingw": [
"-Wl,--dynamicbase",
"-Wl,--nxcompat",
"-Wl,--high-entropy-va",
],
"//python/dist:windows_x86_32_mingw": [
"-Wl,--dynamicbase",
"-Wl,--nxcompat",
],
"//conditions:default": [],
})

# Private alias targets are appended to avoid "duplicate dependency label" errors
# if a user explicitly passes //python/cc:current_py_cc_headers or //python/cc:current_py_cc_libs
# in their deps attribute (including when deps is a select() expression).
Expand Down
Loading