Feat: Core AEAD Cipher Split - #120
Draft
officialfrancismendoza wants to merge 5 commits into
Draft
officialfrancismendoza wants to merge 5 commits into
officialfrancismendoza wants to merge 5 commits into
Conversation
officialfrancismendoza
changed the base branch from
main
to
release/0.1.3alpha
September 8, 2026 11:59
ounsworth
self-requested a review
September 8, 2026 17:03
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ounsworth
requested changes
Sep 8, 2026
Contributor
There was a problem hiding this comment.
Holy crap. This is a 13,000 line PR. That's an insane amount of code to review.
It looks like this PR is bringing (at least) to other PRs with it? What is the actual change here?
I suggest that you either change the merge target to point to another currently-open PR so that the diff to review is smaller (and we can merge this into the other PR), or maybe hold off on this for now and we should focus out effort on reviewing and merging the other PRs first?
officialfrancismendoza
changed the base branch from
release/0.1.3alpha
to
feature/symmetric-cipher
September 8, 2026 17:07
officialfrancismendoza
changed the base branch from
feature/symmetric-cipher
to
feature/officialfrancismendoza/ascon
September 8, 2026 17:07
officialfrancismendoza
force-pushed
the
feature/officialfrancismendoza/119-core-aead-cipher
branch
from
September 9, 2026 08:35
7471ef2 to
01c3e6f
Compare
dghgit
changed the base branch from
feature/officialfrancismendoza/ascon
to
feature/symmetric-cipher
September 9, 2026 11:14
officialfrancismendoza
force-pushed
the
feature/officialfrancismendoza/119-core-aead-cipher
branch
from
September 9, 2026 17:24
01c3e6f to
aa209a9
Compare
Contributor
This was referenced Sep 10, 2026
ounsworth
marked this pull request as draft
September 16, 2026 02:54
…in update_out_len and a FINAL_LEN final buffer so a buffering cipher or an inline ciphertext||tag layout can be expressed; TaggedEncryptor/TaggedDecryptor adapt any FINAL_LEN=0 pair to the SimpleCipherEncryptor/SimpleCipherDecryptor ciphertext||tag shape; the block, simple-cipher and AEAD strength sweeps assert they are not vacuous, and the AEAD streaming suite gains a genuinely-buffering toy plus undersized-buffer and std-one-shot coverage
…XOF128/CXOF128) implementing AEADCipherEncryptor/AEADCipherDecryptor via AsconAead128Encryptor/AsconAead128Decryptor, with HashFactory/XOFFactory registration and CLI wiring including a TaggedDecryptor-based decrypt stream
officialfrancismendoza
force-pushed
the
feature/officialfrancismendoza/119-core-aead-cipher
branch
from
September 17, 2026 13:38
5ba4350 to
2c479f4
Compare
Contributor
Author
officialfrancismendoza
marked this pull request as ready for review
September 17, 2026 13:46
dghgit
changed the base branch from
feature/symmetric-cipher
to
feature/xof-cshake
September 18, 2026 04:05
dghgit
requested changes
Sep 18, 2026
dghgit
left a comment
dghgit
left a comment
Contributor
There was a problem hiding this comment.
See sent Fable report. Looks good mostly though, just a bit further to go.
officialfrancismendoza
marked this pull request as draft
September 18, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements core AEAD cipher split (#119), built off of bcgit/feature/symmetric-cipher. Implements AEADCipherEncryptor and AEADCipherDecryptor, as well as cherry-picks commits from ASCON (#22) so that ASCON is compatible.