Skip to content

Mikeo/lowmem improvements - #136

Open
ounsworth wants to merge 14 commits into
bcgit:release/0.1.3alphafrom
ounsworth:mikeo/lowmem_bench_tweaks
Open

ounsworth wants to merge 14 commits into
bcgit:release/0.1.3alphafrom
ounsworth:mikeo/lowmem_bench_tweaks

Conversation

@ounsworth

@ounsworth ounsworth commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

In short, I had Claude do a review for silent copies in the mlkem and mldsa lowmemory crates and it found a couple of instance of:

  • moves that were being compiled as a pass-by-value copy
  • .try_into() that created a copy as a result of needing an intermediate owned copy.
    And similar patterns.
  • Adjusted the size of the SHAKE pre-buffer in SampleNTT() / RejNTTPoly() to match exactly a SHAKE block size boundary.

The net result is about a 2 - 4 kb reduction across the whole lowmemory suite, and also some tightening up in the non-optimized implementation.

@ounsworth ounsworth changed the title Mikeo/lowmem bench tweaks Mikeo/lowmem improvements Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant