Fix published v12 declaration compatibility - #300
Merged
Merged
Conversation
Coverage Report for CI Build 34172801784Coverage increased (+0.002%) to 95.489%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
bcomnes
marked this pull request as ready for review
September 6, 2026 04:39
bcomnes
commented
Sep 6, 2026
bcomnes
force-pushed
the
bret/fix-v12-declaration-consumer
branch
from
September 7, 2026 21:46
38643f7 to
22d78ee
Compare
bcomnes
force-pushed
the
bret/fix-v12-declaration-consumer
branch
from
September 8, 2026 00:16
26a8adb to
5708bd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpx2@^9.0.1, which fixes the upstream declaration re-export collisions, and retain the dependency-derived copy/static report types.Loggercontract for callers and internal logging; do not introduce a structural logger abstraction or constructor cast.worker_threads.TransferListItemexport used bythread-stream@4.2.0, referenced by both public declaration entry points.devDependencies.typescriptwith Node 22, 24, and 26 declarations, NodeNext resolution, andskipLibCheck: false.Temporary thread-stream compatibility
The upstream fix is pinojs/thread-stream#233, tracked by pinojs/thread-stream#228. Until a compatible dependency release contains it,
types/thread-stream.d.tsrestores the missing alias usingWorkerOptions['transferList']as the source of truth. One targeted@ts-ignorehandles older Node declarations that already export the equivalent alias; the strict packed-consumer checks checks both the missing-alias and duplicate-alias cases.The shim is included in the npm tarball and preserved in both public entry-point declaration references. It does not change runtime behavior, patch installed dependencies, require install scripts, or ask consumers to enable
skipLibCheck. The file documents the upstream PR and removal condition: remove the shim, its entry-point references, and its packaging entry once the supported Pino dependency tree requires the upstream correction.Validation
npm testpassed with Chokidar polling enabled and Chromium installed in a temporary browser directory.cpx2@9.0.1, Pino, and unmodifiedthread-stream@4.2.0, with install scripts disabled.TransferListItemreference; the cpx2 errors were resolved by 9.0.1.Fixes #291.