Deflake eunit: gate live HTTP/3 tests, harden checkout-timeout test#891
Closed
benoitc wants to merge 1 commit into
Closed
Deflake eunit: gate live HTTP/3 tests, harden checkout-timeout test#891benoitc wants to merge 1 commit into
benoitc wants to merge 1 commit into
Conversation
…out test The live-cloudflare HTTP/3 eunit tests depend on the network and intermittently crash the quic h3 library on CI, which destabilizes timing and fails unrelated tests. Gate them behind an opt-in HACKNEY_LIVE_TESTS env so the default run skips them; the HTTP/3 e2e CT suites still cover live testing. Harden test_checkout_timeout: give its first request a generous checkout_timeout so it reliably acquires the single per-host slot under load; only the second request, the one that must time out, keeps the tight 100ms timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
rebar3 eunitrun is flaky on Linux x86_64 CI: the live-cloudflare HTTP/3 eunit tests intermittently crash the quic h3 library (quic_h3_connectiongen_statem), and the resulting load makes the tight-timeouttest_checkout_timeoutrace and fail. Neither is a product regression.HACKNEY_LIVE_TESTSenv via a per-modulemaybe_live/1; the default run skips them. The HTTP/3 e2e CT suites (make http3-e2e-test) still cover live testing. The pure-unitparse_headers_test_stays enabled.test_checkout_timeout: its first request now uses a generouscheckout_timeoutso it reliably acquires the single per-host slot under load; only the second request (which must time out) keeps the tight 100ms timeout.Local
rebar3 eunit(flag unset): all 973 tests pass, no h3 crash reports.