Reject CR/LF/NUL in the CONNECT proxy target host - #921
Merged
Conversation
The CONNECT handshake concatenates the target host into the request line and Host header with no check for control bytes. normalize/2 percent- decodes the host, so a host carrying %0d%0a arrives as raw CRLF and splits the request sent to the proxy. The WebSocket and WebTransport authority builders already guard against this; the proxy handshake did not. Reject CR/LF/NUL in the target host before building any payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CONNECT proxy handshake concatenates the target host into the request line and
Hostheader with no control-byte check.normalize/2percent-decodes the host, so a host carrying%0d%0aarrives as raw CRLF and splits the request sent to the proxy. Reject CR/LF/NUL in the target host before building the payload, matching the WebSocket and WebTransport authority guards that already do this.