Send Content-Length: 0 for empty POST/PUT/PATCH bodies - #925
Merged
Conversation
Like curl, add an explicit Content-Length: 0 when a body-bearing method (POST/PUT/PATCH) is sent with an empty body, unless the caller already set one. Bodyless methods (GET/HEAD/DELETE) stay without it. Fixes servers such as AWS that require Content-Length even for a 0-length body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #917 with curl's convention.
Today hackney sends no Content-Length for an empty body. curl sends an explicit
Content-Length: 0for body-bearing methods (POST/PUT/PATCH) even when the body is empty, and omits it for bodyless methods (GET/HEAD/DELETE). This matches that: POST/PUT/PATCH with an empty body getContent-Length: 0(unless the caller already set one); GET/HEAD/DELETE are unchanged.Fixes servers that require the header on a 0-length body, e.g. the AWS case reported in aws-beam/aws-elixir#238 (surfaced in #917).
Note vs #917: it stored the integer
0(breaks thehackney_headers:storebinary-value contract, which is why its dialyzer job failed) and added the header for every method. This uses<<"0">>and scopes it to body-bearing methods.