Repository navigation
Reset the streams a GOAWAY refuses - #965
Merged
Merged
Conversation
hackney failed the streams above last_stream_id but left them open in h2, so they lingered until the connection closed. h2 0.12.4 accepts cancel_stream after a GOAWAY, so each newly refused stream now gets an RST_STREAM when the GOAWAY arrives. Accepted streams are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streams refused by a GOAWAY (ids above last_stream_id) were failed locally but never reset, so h2 kept them open until the connection closed. With h2 bumped to 0.12.4, which accepts cancel_stream after a GOAWAY, each newly refused stream now gets an RST_STREAM when the GOAWAY arrives, including refused uploads. Accepted streams are not touched.