Repository navigation
fix(code init): use the actual /connect method labels in login copy - #93
Merged
Merged
Conversation
The plugin renamed its auth methods in 1.1/1.2 (PRs #42/#43): users now see 'Berget Code Seat - Login using this device' and 'Berget API Key - Enter API key manually', not 'Login with Berget' / 'Enter Berget API Key manually'. Instructions referencing the old labels send new users hunting for menu entries that no longer exist.
![berget-ai[bot]](https://avatars.githubusercontent.com/u/160869282?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review
Summary
Updates the OpenCode login-instruction copy in TOOL_LOGIN_METHODS (the declared single source of truth for login text) to "Berget Code Seat - Login using this device" / "Berget API Key - Enter API key manually", with the corresponding test assertion updated.
Risk
LOW — This is a UI copy change flowing through existing constants; all consumers (init.ts bullets/instructions) derive from TOOL_LOGIN_METHODS so the change propagates consistently, and the one test that asserts on the copy was updated in lockstep.
Issues
None.
Verification performed:
- The old strings ("Login with Berget", "Enter Berget API Key manually") have no remaining references anywhere in the repo (source, tests, e2e, docs).
- All copy consumers (
init.ts:171next-steps bullets,SUBSCRIPTION_LOGIN_INSTRUCTIONS,API_KEY_LOGIN_INSTRUCTIONS,LOGIN_METHOD_BULLETS) are computed fromTOOL_LOGIN_METHODS, so no site can drift. auth-sync.test.ts:238asserts on the "Berget Code Seat" substring, which is contained in the new subscription string, so the test still validates the note path; other tests are substring-based on/connect,/login, and the API key and are unaffected.- No security, breaking-change, performance, or operational implications — no behavior, paths, or contracts changed.
Suggestions
None.
Architecture
Not applicable — no structural change.
Inline findings
Berget AI (berget/zai-org/GLM-5.3-Flash) | PR #93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #91. The opencode-berget-auth plugin renamed its auth methods (PRs #42/#43, live since 1.1/1.2.0 — confirmed in the original customer report: the user selected "Berget Code Seat - Login using this device"). Our instructions still referenced the old labels:
Two strings in
TOOL_LOGIN_METHODS+ one test assertion. 265 tests green, lint/typecheck/format clean.