Skip to content

Fix broken check-advisories CI check - #26243

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
stuartparmenter:ignore-zbus-unmaintained-advisories
Oct 20, 2026
Merged

alice-i-cecile merged 1 commit into
bevyengine:mainfrom
stuartparmenter:ignore-zbus-unmaintained-advisories

Conversation

@stuartparmenter

Copy link
Copy Markdown
Contributor

Objective

Fix the failing check-advisories CI check.

Solution

Ignore three maintenance advisories for zvariant, zbus_names, and zvariant_derive, which were merged into zbus 6, matching AccessKit’s upstream fix.

These crates are pulled in through bevy_winit → accesskit_winit → accesskit_unix → AT-SPI / zbus. The latest AccessKit and AT-SPI releases still depend on zbus 5. AccessKit cannot upgrade yet because zbus 6 requires Rust 1.89. Removing these exceptions will require upstream migrations and an update to Bevy’s Linux game-mode integration, which also depends directly on zbus and uses its removed blocking API.

Testing

cargo deny check advisories no longer reports these three advisories.

AI Disclosure

Used Codex to investigate CI logs and upstream dependencies and add the advisory exceptions.

@stuartparmenter stuartparmenter added C-Dependencies A change to the crates that Bevy depends on S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 18, 2026
@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy A-Meta About the project itself labels Oct 18, 2026
@stuartparmenter stuartparmenter added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 18, 2026
@alice-i-cecile alice-i-cecile added X-Contentious There are nontrivial implications that should be thought through D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 18, 2026

@alice-i-cecile alice-i-cecile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved following upstream guidance in AccessKit/accesskit#834. It would be nice to fix these in earnest, but that's out of our hands.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 18, 2026
@alice-i-cecile
alice-i-cecile added this pull request to the merge queue Oct 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 20, 2026
@alice-i-cecile
alice-i-cecile added this pull request to the merge queue Oct 20, 2026
Merged via the queue into bevyengine:main with commit d1cbc9a Oct 20, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Meta About the project itself C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Contentious There are nontrivial implications that should be thought through

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants