Repository navigation
fix(restore): scrub tamanu sync and device identity on every restore - #164
Closed
dannash100 wants to merge 2 commits into
Closed
dannash100 wants to merge 2 commits into
dannash100 wants to merge 2 commits into
Conversation
1 of 23 tasks
1 task
Contributor
Author
|
🤖 Superseded by #165: replicas never hold the source's key, so the identity only needs clearing where Tamanu actually runs against a restore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A restored Tamanu database still holds the source server's sync host, sync credentials and device identity, so anything started against a replica (or a copy taken from one) can sync or report status as prod.
forget_server_identity()(db: TAM-7176: add forget_server_identity() for copied databases tamanu#11378) when the snapshot has it, else deletes the same keys inline.ON_ERROR_STOPso a failed scrub fails the restore. Both branches checked on a Tamanu facility schema with the DB set read-only.