Repository navigation
[BY-3620]: Make retry work with Node's fetch, and only retry safe requests - #48
Merged
Merged
Conversation
commit: |
alexdilley
reviewed
Sep 30, 2026
alexdilley
left a comment
Contributor
There was a problem hiding this comment.
Can't tell if we want to actually retry on ECONNRESET as a library default or not.
paulambanks
force-pushed
the
feature/by-3620
branch
from
September 30, 2026 12:21
f8a81a6 to
1942645
Compare
alexdilley
reviewed
Sep 30, 2026
paulambanks
force-pushed
the
feature/by-3620
branch
2 times, most recently
from
September 30, 2026 12:43
76c5b15 to
6d53d47
Compare
alexdilley
approved these changes
Sep 30, 2026
paulambanks
force-pushed
the
feature/by-3620
branch
from
September 30, 2026 13:00
6d53d47 to
167fd67
Compare
alexdilley
approved these changes
Sep 30, 2026
paulambanks
force-pushed
the
feature/by-3620
branch
2 times, most recently
from
September 30, 2026 13:17
aa187f9 to
7b37fb7
Compare
paulambanks
force-pushed
the
feature/by-3620
branch
from
September 30, 2026 13:22
7b37fb7 to
a813f40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
Impact: no existing app changes behaviour. Apps that enable retry: { attempts: 2, errors: ['ECONNRESET'] } get one automatic retry on reset GET requests.