Refractor WalletRuntime load to Combine wallet DB dir setup and config loading into one function - #319
Open
emma31-dev wants to merge 1 commit into
Open
Conversation
emma31-dev
force-pushed
the
walletruntimeconfigrefractor
branch
from
September 5, 2026 17:59
1565f0a to
dbae612
Compare
Combine `prepare_wallet_db_dir` and `load_wallet_config` into a single function that returns the database path alongside wallet options and network, reducing code duplication in the `WalletRuntime` loader. Signed-off-by: emma31-dev <emmanuelfidel07@gmail.com>
emma31-dev
force-pushed
the
walletruntimeconfigrefractor
branch
from
September 5, 2026 18:02
dbae612 to
2bdeb3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merges
prepare_wallet_db_dirandload_wallet_configinto a singleprepare_wallet_db_dir_and_configfunction that returns the database path alongside WalletOpts and Network.The two functions were always called together in WalletRuntime::load, so combining them removes the duplication and simplifies the call site.
Notes to the reviewers
The main reason for this change is because the two functions merged were single-use.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingThank you.