Skip to content

Gate backend-specific full_scan options - #367

Open
emma31-dev wants to merge 3 commits into
bitcoindevkit:masterfrom
emma31-dev:fix/full-scan-backend-options
Open

emma31-dev wants to merge 3 commits into
bitcoindevkit:masterfrom
emma31-dev:fix/full-scan-backend-options

Conversation

@emma31-dev

@emma31-dev emma31-dev commented Oct 25, 2026 •

Copy link
Copy Markdown

Description

Make full_scan options reflect backend support: gate --scan-stop-gap to Electrum/Esplora builds and make Esplora's --parallel-request an optional override of the wallet-configured request count. Related to #340 .

Notes to the reviewers

The RPC backend still scans blocks through Emitter and does not use stop_gap as a lookahead. This change removes the option from RPC-only builds but does not make RPC discover funds beyond its current lookahead. In builds with multiple backend features enabled, the compile-time flag may still be available when the wallet is configured for RPC.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Make the parallel request option Esplora-only and optional, using
the wallet's configured value unless overridden. Limit stop-gap to
Electrum and Esplora.
@emma31-dev
emma31-dev force-pushed the fix/full-scan-backend-options branch from 2fc5eb8 to 922dd64 Compare October 25, 2026 15:55
@emma31-dev emma31-dev changed the title Allow overriding Esplora scan parallelism Gate backend-specific full_scan options Oct 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant