feat(wallet): add configurable min_output_value filter#427
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #427 +/- ##
==========================================
+ Coverage 80.96% 81.15% +0.19%
==========================================
Files 24 24
Lines 5489 5530 +41
Branches 247 247
==========================================
+ Hits 4444 4488 +44
+ Misses 968 965 -3
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Concept ACK. Related with the Also, #431 rewrites |
Adds runtime-only min_output_value to Wallet for operational dust filtering on balance, list_unspent, and coin selection. Accounting/history methods (sent_and_received, tx_details, list_output) remain factual.
|
Yes agree, thanks. I think I included it because #375 asked for it too. Bit weird in hindsight and can cause inconsistencies. So the key parts to filter are |
Description
Adds a runtime-only
min_output_value: Option<Amount>setting toWalletfor dust/spam filtering. It filters wallet-visible spendable value inbalance,list_unspent, and automatic coin selection without changing accounting functions.Closes #375
Notes to the reviewers
min_output_valuerather thandust_thresholdto avoid confusion with the existing coin selectiondust_thresholdand Bitcoin's relay dust policy.CreateParams::min_output_value()/LoadParams::min_output_value(), or changed at runtime viaWallet::set_min_output_value().bdk_wallet, not pushed down intobdk_chain.Changelog notice
min_output_valuesupport toWallet,CreateParams, andLoadParamsbalance,list_unspent, and coin selection now honormin_output_valueChecklists
All Submissions:
just pbefore pushingNew Features: