Repository navigation
chore!: bump MSRV to 1.75 - #31
Merged
Merged
Conversation
noahjoeris
force-pushed
the
chore/msrv-1.75
branch
from
October 20, 2026 17:08
c7b4438 to
0408bb9
Compare
noahjoeris
force-pushed
the
chore/msrv-1.75
branch
from
October 20, 2026 19:35
0408bb9 to
ec66da7
Compare
evanlinjin
reviewed
Oct 21, 2026
evanlinjin
left a comment
evanlinjin
left a comment
Member
There was a problem hiding this comment.
Btw, the commit message is wrong:
Match the MSRV of electrum-client and LDK's lightning-transaction-sync so LDK can adopt this crate
without raising its own MSRV.
We are raising the MSRV here so it wouldn't help at all.
Contributor
Author
|
Yes thanks, will update. Claude got out of control 🤖 |
noahjoeris
force-pushed
the
chore/msrv-1.75
branch
from
October 21, 2026 14:28
ec66da7 to
3467d88
Compare
noahjoeris
force-pushed
the
chore/msrv-1.75
branch
from
October 25, 2026 14:44
3467d88 to
799b477
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
=======================================
Coverage 48.33% 48.33%
=======================================
Files 11 11
Lines 902 902
Branches 18 18
=======================================
Hits 436 436
Misses 461 461
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Match electrum-client's MSRV. Use `io::Error::other`, which Clippy requires once the MSRV is 1.74 or higher. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
noahjoeris
force-pushed
the
chore/msrv-1.75
branch
from
October 25, 2026 15:22
799b477 to
dc49500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump MSRV from 1.70 to 1.75 to match
electrum-client(1.75).Changelog notice
- Breaking: Raise MSRV to 1.75.🤖 Generated with Claude Code