Expose negotiated protocol version#213
Open
tnull wants to merge 2 commits into
Open
Conversation
The v1.6 upgrade negotiated and stored the server protocol version during connection setup, but omitted the documented public API for reading it. Add protocol_version() so callers can reuse the negotiated value. Only fall back to server.version when no cached version exists. Co-Authored-By: HAL 9000
oleonardolima
force-pushed
the
2026-06-expose-protocol-version
branch
from
c2a5d17 to
f78ed74
Compare
oleonardolima
left a comment
oleonardolima
left a comment
Collaborator
There was a problem hiding this comment.
utACK f78ed74
Overall it looks good! I pushed a commit fixing the CI, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.6 upgrade negotiated and stored the server protocol version during connection setup, but omitted the documented public API for reading it.
Add protocol_version() so callers can reuse the negotiated value. Only fall back to server.version when no cached version exists.