fix: handle concurrent rustls cryptoprovider initialization#217
Open
reez wants to merge 2 commits into
Open
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216
References bitcoindevkit/bdk-dart#103
When multiple SSL clients are created concurrently more than one caller can observe that no process-default rustls
CryptoProvideris installed. This keeps the existing install path, but ifinstall_default()fails, it re-checks whether a default provider is now present and treats that as success.I tried to look for broader context/discussion in things like #171 (comment) and #171 (comment). This keeps the existing
get_default()guard behavior, but also handles the concurrent "first use" case where another caller installs the provider after the initial check.