pin delete: delete a share you made - #6
Open
terraboops wants to merge 1 commit into
Open
terraboops wants to merge 1 commit into
terraboops wants to merge 1 commit into
Conversation
pin's end-to-end suite runs against production through this CLI and left
every share it made behind (Operate's review of pin#43). pin delete sends
DELETE /api/pins/{id}; the server lets only the share's owner delete it
(bitcomplete/pin#43).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Sn3acTQsYfyvVidkmhCC5j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
pin delete <id-or-url>, which sendsDELETE /api/pins/{id}.The server side is in bitcomplete/pin#43: pin records each share's owner (the signed-in subject) at upload, and only that owner can delete it. Anyone else gets 403. A share made before owners were recorded also gets 403.
Why: pin's end-to-end suite runs against production through this CLI and left every share it made behind. With this command the suite deletes everything it creates and fails if any of it still serves.
deleted <id>, exit 0not found: <id>, exit 1http <code>: <body>, exit 1Test:
delete_test.godrivesdeleteShareagainst an httptest server for 204, 404 and 403. Lint shows the same 12 findings as main (none new).Merge order: bitcomplete/pin#43 must be live before this command can work against production. Until then the server answers 405.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Sn3acTQsYfyvVidkmhCC5j