fix(bws): bind TSS keygen partyId to the submitting copayer - #4246
Open
SashaMIT wants to merge 1 commit into
Open
fix(bws): bind TSS keygen partyId to the submitting copayer#4246SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Sign already checks (copayerId, partyId). Keygen only tested whether the slot was empty, so a later submitter could use another partyId.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TSS sign already binds
(copayerId, partyId)before accepting a round message. Keygen only checked whether the party slot was empty.That let a later submitter use someone else's
partyId(or claim a second slot) once the session existed.partyIdwas also unbounded, so a value>= nskipped the occupancy check.This adds the same ownership bind: one copayer, one in-range slot.
Test plan
assertKeygenPartyOwnershipcovers empty slot, owner resubmit, stolen slot, second slot, andpartyId >= nMade with Cursor