Skip to content

fix(bws): bind TSS keygen partyId to the submitting copayer - #4246

Open
SashaMIT wants to merge 1 commit into
bitpay:masterfrom
SashaMIT:fix/tss-keygen-bind-party-to-copayer
Open

fix(bws): bind TSS keygen partyId to the submitting copayer#4246
SashaMIT wants to merge 1 commit into
bitpay:masterfrom
SashaMIT:fix/tss-keygen-bind-party-to-copayer

Conversation

@SashaMIT

Copy link
Copy Markdown

Summary

TSS sign already binds (copayerId, partyId) before accepting a round message. Keygen only checked whether the party slot was empty.

That let a later submitter use someone else's partyId (or claim a second slot) once the session existed. partyId was also unbounded, so a value >= n skipped the occupancy check.

This adds the same ownership bind: one copayer, one in-range slot.

Test plan

  • assertKeygenPartyOwnership covers empty slot, owner resubmit, stolen slot, second slot, and partyId >= n
  • Revert-tested: without the bind, a second copayer is accepted on an occupied slot

Made with Cursor

Sign already checks (copayerId, partyId). Keygen only tested whether
the slot was empty, so a later submitter could use another partyId.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant