Add Apple MPS NF4 benchmark - #2057
Open
hamedrabah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a standalone Apple MPS benchmark for the now-supported NF4 path. It
measures:
absmaxmetadata size relative to fp32Linear4bitlatency and output error relative to dense fp16The benchmarking README includes the command and the script exposes tensor
size, layer size, warm-up, and repetition controls. Results are reported rather
than asserted so the benchmark remains useful across Apple Silicon variants.
Validation
Tested on Apple M4 / macOS 15.7.9 with PyTorch 2.13.0 against the current
checkout (
bitsandbytes 0.50.2.dev0):The existing 4-bit test selection was also exercised on MPS: 252 passed, 36
skipped, 60 xfailed, and 426 deselected.