Repository navigation
[PM-45006] chore: Migrate from glide to coil for async image loading - #7465
david-livefront wants to merge 1 commit into
Conversation
github-actions
Bot
added
app:password-manager
| * type Network. | ||
| * @return An IconCompat created from the IconData or the default resource. | ||
| */ | ||
| suspend fun Context.createFido2IconCompatFromIconDataOrDefault( |
There was a problem hiding this comment.
This was never being used.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7465 +/- ##
==========================================
- Coverage 86.80% 86.79% -0.01%
==========================================
Files 895 894 -1
Lines 65676 65653 -23
Branches 9384 9383 -1
==========================================
- Hits 57007 56984 -23
Misses 5189 5189
Partials 3480 3480
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: REQUEST CHANGES This PR replaces Glide with Coil 3 for loading images in the Code Review Details
Dependency Changes
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| androidxSplash = "1.2.0" | ||
| androidxWork = "2.11.2" | ||
| bitwardenSdk = "4.0.0-9318-3b2c8fc3" | ||
| coil = "3.6.3" |
There was a problem hiding this comment.
io.coil-kt.coil3 (coil, coil-compose, coil-gif, coil-network-okhttp 3.6.3) added with no AppSec approval signal.
Details and fix
Coil is net-new to the codebase; it is not a version bump of Glide. Bitwarden requires AppSec approval before a new dependency goes in, and that applies to all four artifacts added here. The PR description has no VULN task reference and doesn't mention the approval process.
Please contact the AppSec team to start the Dependency Review and Approval process, then add the VULN task reference to the PR description.
vvolkgang
left a comment
vvolkgang
left a comment
There was a problem hiding this comment.
Looks great mate, thanks for moving forward with this! Summary of what we discussed for my own sake:
- Wait for VULN-1208.
- Explain in the ticket description why we couldn't update glideCompose so we have context if we need to look back in the future.
- Add a ticket for QA testing, specially in self-host / mTLS / enterprise scenarios.
c1c5302 to
62fb4c3
Compare
vvolkgang
changed the title
This branch has not been deployed
2 participants
🎟️ Tracking
PM-45006
VULN-1208
📔 Objective
This PR migrates the app from using Glide for async image loading to Coil. Glide not been update-able due to API issues for quite some time now and using Coil would be allow us to continue to move forward without having a stagnant dependency in the app.
The Coil repository can be found here.
Glide status as of October 14th, 2026:
More details on why Glide cannot be updated can be found here.