Add e2e tests and db fix - #4
Open
blint wants to merge 19 commits into
Open
Conversation
Signed-off-by: Balint Kovacs <blint@blint.hu>
as described in https://android-developers.blogspot.com/2013/08/some-securerandom-thoughts.html Signed-off-by: blint@blint.hu
Signed-off-by: Balint Kovacs <blint@blint.hu>
Signed-off-by: Balint Kovacs <blint@blint.hu>
This is the only way to run non-system background services that are not job-oriented on and above Oreo Unfortunately this also prevents me to remove the much-hated persistent notification Signed-off-by: Balint Kovacs <blint@blint.hu>
…ew platforms and API
…cking the CA cert file
Add a JVM-based test suite (Robolectric) and fix a regression this branch introduced in tunnel persistence. Fix: - SSLDroidDbAdapter.createContentValues silently dropped the cacertfile and usesni columns. This lost CA-pinning and SNI settings on save, and on a fresh install (usesni INTEGER NOT NULL, no default) it violated the NOT NULL constraint so insert() returned -1 and tunnels could not be saved at all. Persist both columns and drop a duplicated remoteport put(). Tests: - TcpProxyE2ETest: end-to-end tunnel through the real TcpProxy in front of a real TLS backend (no-pinning, matching-CA, and wrong-CA rejection cases). - SSLDroidDbAdapterTest: CRUD + stop-status, incl. a regression test for the fix. - TlsTestBackend + generated PKCS12/PEM fixtures under tests/resources. Build/CI: - Wire up a JVM unit-test source set (tests/), Robolectric/JUnit deps, android.useAndroidX=true, and the JDK 17 --add-opens flags Robolectric needs. - Add .github/workflows/ci.yml to run the suite on GitHub Actions. Housekeeping: - Untrack .idea/ and local.properties and add them to .gitignore. - docs/branch-review.md documents the review findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.