Skip to content

remove random_seed from presets - #383

Merged
blkerby merged 5 commits into
blkerby:mainfrom
nn357:seedno-fix
Oct 5, 2026
Merged

blkerby merged 5 commits into
blkerby:mainfrom
nn357:seedno-fix

Conversation

@nn357

@nn357 nn357 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@blkerby

blkerby commented Oct 3, 2026

Copy link
Copy Markdown
Owner

It doesn't seem to work: the random_seed still gets wiped out by the assignment *settings = serde_json::to_value(p)?;. I think to solve it we want to pull random_seed out of the settings structure entirely (i.e. remove it from being a field in OtherOptions)?

@nn357

nn357 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

It doesn't seem to work: the random_seed still gets wiped out by the assignment *settings = serde_json::to_value(p)?;. I think to solve it we want to pull random_seed out of the settings structure entirely (i.e. remove it from being a field in OtherOptions)?

oh? it worked on my local build, i dont think i changed anything else either?

@nn357

nn357 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

It doesn't seem to work: the random_seed still gets wiped out by the assignment *settings = serde_json::to_value(p)?;. I think to solve it we want to pull random_seed out of the settings structure entirely (i.e. remove it from being a field in OtherOptions)?

yeah! looking at my dev branch there was other stuff i did that i didnt commit :D

@nn357

nn357 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

It doesn't seem to work: the random_seed still gets wiped out by the assignment *settings = serde_json::to_value(p)?;. I think to solve it we want to pull random_seed out of the settings structure entirely (i.e. remove it from being a field in OtherOptions)?

I pushed the rest of the changes that made it work!

might be a more elegant way to do this, it was pretty late when i was tinkering with it.

Comment thread rust/maprando-web/src/main.rs Outdated
nn357 and others added 2 commits October 4, 2026 13:12
Co-authored-by: Brent Kerby <blkerby@gmail.com>
@blkerby
blkerby merged commit b243223 into blkerby:main Oct 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants