Repository navigation
feat(cli): admin-less deploy names what it leaves out, and why - #504
Merged
Merged
Conversation
The admin-less profile drops the Strimzi operator, cert-manager, Kyverno, Litmus and the monitoring stack, and they used to vanish from the wizard's component list and the Component Selection phase without a word. Both now list them with the reason: cluster-wide CRDs, roles or webhooks that need cluster admin. Monitoring's line follows the cluster: no Prometheus operator to scrape for, the wizard's PodMonitors option, or the scrape already chosen. The scrape-only choice also gets its own line in the Component Selection phase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2 of the deploy plan (
plans/deploy-enhancement.md): every component listed, with the reason it is off.What changes
The admin-less profile leaves out the Strimzi operator, cert-manager, Kyverno, Litmus and the monitoring stack. Until now they disappeared from the wizard's component list and from the "Component Selection" phase without a word.
Not installed: …lines in the Component Selection phase. The scrape-only monitoring choice gets its own ✓ line there too.The admin/admin-less check is unchanged. The plan also listed
adminlessSuggestion/strimziInstallSuggestionunder the note. I left them out: deploy already prints them where they apply, before the wizard and in the Strimzi check.Checks
TestPrintComponentSelection_AdminlessNamesWhatIsLeftOutcovers no operator, an operator, and the scrape chosen.go test ./cmdpasses.golangci-lint run --new-from-rev=origin/mainreports 0 issues.scripts/check-cli-style.shpasses.kind-panda, read-only through a copied kubeconfig:kates deploy --adminless --topology single --namespace kafka --dry-run --yesprints the four lines.kates deploy -i --adminless …, driven in an 80×24 tmux pane up to the component screen and then cancelled, shows the note on the same page as the list.--with-monitoringand the flag's help text have the same misnomer; they are left for a separate change.