Repository navigation
fix(cli): clean uninstalls the kafka-ui release - #505
Merged
Merged
Conversation
kates deploy installs Kafka UI as the kafka-ui release, but clean did not list it. Clean then saw a release it does not own in the kafka namespace, kept the namespace, and with the Kafka cluster still in it kept the Strimzi operator too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After
kates clean,kates deploy statusstill showed the Strimzi operator and Kafka UI as deployed.kates deployinstalls Kafka UI as thekafka-uiHelm release (in--ui-ns, defaultkafka), but clean's release list didn't include it. Clean refuses to delete a namespace that holds a release it doesn't own, so it keptkafka. ThekrafterKafka and its KafkaUsers stayed with it, so clean kept the Strimzi operator, its namespace and its CRDs as still in use. Clean reported all this in its kept list, but it read as clean not working.Change
kafka-uijoins clean's app releases: in--namespacefor the single topology and in--kafka-nsfor isolated.Checked
go test ./cmdandgolangci-lint --new-from-revpass.--yes) now lists thekafkaandstrimzi-operatornamespaces and the Strimzi CRDs for deletion.Deliberately not done
Clean has no
--ui-nsflag, so a Kafka UI deployed with a custom--ui-nsin the isolated topology is still looked for in--kafka-ns.