Reconcile upstream through 16bc05a2 (Go asserted locals, native)

[bompus]

Merges upstream main through 16bc05a2 (upstream colbymchenry#2478) into fork/consolidated.

colbymchenry#2478: a Go local bound from a type assertion (f, ok := w.(http.Flusher), wr := v.(*Wrapper)) has the asserted type. Upstream implements it in src/resolution/name-matcher.ts, which the fork deleted, so the merge keeps that deletion and ports the rule to the native resolver instead:

• New codegraph-kernel/src/resolve/go_asserted.rs reads the declaration of the receiver in scope from the syntax tree (blocks, if/for/switch initializers, range and type-switch variables, parameters, var specs; comments declare nothing). A := or var whose whole value is one assertion gives the asserted type; any other declaration leaves the call to the existing strategies.
• The type is found as Go finds it: own package or dot-imported package for a bare name, imported project package for pkg.T, aliases followed. A type from outside the project or a predeclared one links nothing; a type literal or a function-local type is left to the other strategies.
• Wired into the method-call and no-evidence method-call arms, function refs (register(st.Fetch)), the 2-hop field chain (wr.job.Start()), and the standard-library-package prefilter (a local named parser is the local).
• Upstream's __tests__/go-asserted-locals.test.ts is kept. Two assertions are adapted to the fork's existing rule that a callee is not name-guessed for a receiver whose type the project does not declare: a type-literal / function-local asserted type (Unseen) and a type-switch variable (Switched) stay unlinked where upstream name-matches them to sink::Drain. Both behave this way on fork/consolidated before this change.

CHANGELOG: this range's entry; a duplicate of an earlier Go-assertion entry the merge re-inserted is dropped. README merge point moved to 16bc05a2.

Checks: full suite 681 files / 8701 tests passed, no worker crashes; golden dumps unchanged; eval:precision gin 3/3 held; kernel built with no warnings.

README rows checked: merge point (2 places) updated; no fork-vs-upstream row changes.

Lands as a merge commit (not squash) to keep upstream ancestry.

Summary by CodeRabbit

• New Features
  • Go method calls on variables created through type assertions now link to matching methods on project types, including methods promoted from embedded types.
  • Corrected handling of asserted types from outside the project: these calls remain unresolved rather than linking to unrelated project methods.
  • Variables named after standard-library packages are no longer automatically treated as package references when they hold local asserted values.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: df27f4bb-7255-43c8-a25e-bb270bf46421

---

📥 Commits

Reviewing files that changed from the base of the PR and between 05d5ad3 and d783a3f.

---

📒 Files selected for processing (9)

• CHANGELOG.md
• README.md
• __tests__/go-asserted-locals.test.ts
• codegraph-kernel/src/resolve/fields.rs
• codegraph-kernel/src/resolve/go_asserted.rs
• codegraph-kernel/src/resolve/member_fn_ref.rs
• codegraph-kernel/src/resolve/method_call.rs
• codegraph-kernel/src/resolve/mod.rs
• codegraph-kernel/src/resolve/prefilter.rs

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

---

📝 Walkthrough

Walkthrough

Go receiver resolution now uses types established by local type assertions to find project methods, including promoted methods. Asserted external types do not resolve to project methods. Tests cover resolution cases across the default and WASM backends. The README upstream baseline and changelog entry were also updated.

Changes

Go asserted-local method resolution

Layer / File(s)	Summary
Identify and resolve asserted local types codegraph-kernel/src/resolve/go_asserted.rs, codegraph-kernel/src/resolve/mod.rs	New resolver helpers identify in-scope locals assigned type assertions and classify asserted types as project or outside types.
Apply asserted types to receiver resolution codegraph-kernel/src/resolve/member_fn_ref.rs, codegraph-kernel/src/resolve/method_call.rs, codegraph-kernel/src/resolve/fields.rs, codegraph-kernel/src/resolve/prefilter.rs	Member, method-call, field-chain, and standard-library prefilter paths now check asserted-local resolution before or alongside existing receiver inference.
Validate and document resolution __tests__/go-asserted-locals.test.ts, CHANGELOG.md	Tests cover asserted types, scope and shadowing cases, method values, and unlinked decoys across both backends. The changelog records the resolution behavior.

README upstream reference

Layer / File(s)	Summary
Update upstream comparison baseline README.md	The fork description and feature comparison now identify upstream commit 16bc05a2.

---

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to d783a

The asserted-local resolution change has no identified issue requiring a fix before merge.

Pre-merge checks | 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the upstream reconciliation through commit 16bc05a and the main feature, Go asserted-local resolution. It is concise and related to the changeset.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Suppressions Explained		The pull request adds no lint, type-check, or compiler suppression directive. The changed files contain no new eslint-disable, @ts-expect-error, @ts-ignore, #[allow(...)], noqa, or lint/type…
User-Visible Changes Documented		The pull request changes Go resolver behavior, tests, CHANGELOG.md, and README.md merge-point references. It does not add, remove, or rename a CLI command or flag, MCP tool or argument, supported lang…

---

✨ Finishing Touches 💡 1

📝 Generate docstrings

• Commit to this branch
• Create a new PR

---

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}