Skip to content

Fix conversion of exactly representable double -2^63 to int64_t - #1210

Open
Tyagiquamar wants to merge 1 commit into
boostorg:developfrom
Tyagiquamar:fix-double-min-int64
Open

Tyagiquamar wants to merge 1 commit into
boostorg:developfrom
Tyagiquamar:fix-double-min-int64

Conversation

@Tyagiquamar

Copy link
Copy Markdown

Fixes #1209. The lower-bound helper for signed 64-bit integer conversion returned the next double above INT64_MIN, rejecting the exact minimum. Return the exact minimum value.

Signed-off-by: Tyagiquamar <Tyagiquamar@users.noreply.github.com>
@cppalliance-bot

cppalliance-bot commented Oct 12, 2026 •

Copy link
Copy Markdown

An automated preview of the documentation is available at https://1210.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-10-12 12:58:56 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://1210.json.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://1210.json.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff Report https://1210.json.prtest2.cppalliance.org/diff-report/index.html

Build time: 2026-10-12 13:17:31 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://1210.json.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://1210.json.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff Report https://1210.json.prtest2.cppalliance.org/diff-report/index.html

Build time: 2026-10-12 13:20:17 UTC

@cppalliance-bot

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.98%. Comparing base (87c2e5e) to head (abfaa4f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1210   +/-   ##
========================================
  Coverage    93.98%   93.98%           
========================================
  Files           85       85           
  Lines         8971     8971           
========================================
  Hits          8431     8431           
  Misses         540      540           
Files with missing lines Coverage Δ
include/boost/json/detail/value.hpp 98.46% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c2e5e...abfaa4f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cppalliance-bot

Copy link
Copy Markdown

@grisumbras

Copy link
Copy Markdown
Member

Thanks for the fix. In addition to the fix I need a test that fails with current state of the project but would pass with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exact double -2^63 is rejected by conversion to std::int64_t

3 participants