ci: show failed unit details when boot smoke test is degraded - #184
Merged
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
1 task
Contributor
Author
|
Hm well on main this doesn't exercise the |
Contributor
Author
|
ok that's much more useful |
Contributor
Author
cgwalters
enabled auto-merge (rebase)
May 14, 2026 11:58
Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: John Eckersberg <jeckersb@redhat.com>
Contributor
Author
|
Noticed this was still open while going through and cleaning out old TODOs, rebased it, should still be good to go if everything passes still. |
Contributor
Author
|
Notable because #194 is still showing |
cgwalters
approved these changes
Jul 31, 2026
cgwalters
reviewed
Jul 31, 2026
| run: | | ||
| image="localhost/${{ matrix.name }}:${{ matrix.tag }}" | ||
| bcvk ephemeral run-ssh "${image}" -- systemctl is-system-running | ||
| bcvk ephemeral run-ssh "${image}" -- bash -c ' |
Contributor
There was a problem hiding this comment.
I think the best fix though is in bootc-dev/bcvk#244
For now I think we're likely still blocked on coreos/bootupd#1072
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: John Eckersberg jeckersb@redhat.com