mount: tell why FUSE support is unavailable - #10159
Merged
ThomasWaldmann merged 1 commit intoAug 21, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10159 +/- ##
==========================================
- Coverage 87.00% 87.00% -0.01%
==========================================
Files 101 101
Lines 17996 18002 +6
Branches 2738 2738
==========================================
+ Hits 15657 15662 +5
- Misses 1635 1637 +2
+ Partials 704 703 -1 ☔ View full report in Codecov by Harness. |
- fuse_impl: record the import error of each FUSE implementation that failed to load. also catch non-ImportError failures: mfusepy raises OSError at import time if libfuse is missing (and AttributeError / NotImplementedError in other cases), which previously crashed borg with a traceback instead of a clean error. - borg mount: show the recorded errors, so users see the actual cause (e.g. a missing shared library) instead of just "no FUSE support". - sysinfo: report mfusepy as the active FUSE implementation (it showed "fuse: None" although mounting worked) and include the recorded import errors if no implementation loaded, so debug output pasted into issues shows why. - docs: note that third-party binaries might lack FUSE support. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ThomasWaldmann
force-pushed
the
mount-fuse-errors-8657
branch
from
August 21, 2026 10:41
8e37306 to
2927349
Compare
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the actionable part of #8657 (see also #8388):
borg mountonly said no FUSE support without any hint at the cause, so users could not tell "not installed" from "installed, but broken" (e.g. a pyfuse3 wheel linked against a libfuse soname that no longer exists).fuse_impl: record the import error of each FUSE implementation that failed to load in a new
fuse_import_errorsdict. Also catch non-ImportErrorfailures: mfusepy raisesOSErrorat module import time if libfuse is missing (andAttributeError/NotImplementedErrorin other cases). Since mfusepy is the first default implementation, that previously crashedborg mount— andsysinfo()in exception handlers — with a raw traceback on any host without libfuse.borg mount: show the recorded errors:
sysinfo: it reported
fuse: Nonewhen mfusepy was the active implementation (it only looked atllfuse). Now it reports the active module (mfusepy has no__version__, so the version is best-effort) and includes the recorded import errors when no implementation loaded — so the debug output users paste into issue reports shows the cause directly.tests: new
test_fuse_import_errors_recordedcovering the OSError case and the error recording.docs: note in the Standalone Binary section that third-party binaries might lack FUSE support and that OS-level FUSE is needed.
A 1.4-maint backport of the diagnostic part would be easy if wanted (1.4 only has pyfuse3/llfuse, so the OSError hazard does not exist there).
🤖 Generated with Claude Code