fix(annotator): isolate active threads per pane in side-by-side preview - #790
Merged
Merged
Conversation
A shared EventManager broadcasts ACTIVE_SET to every annotator. Ignore ids this pane does not own and clear the local thread without notifying the host. Do not render an empty composer for a thread this pane does not own.
zhirongwang
force-pushed
the
fix/isolate-active-threads-per-pane
branch
from
September 18, 2026 23:05
a3afcf4 to
13779ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseAnnotatornow ignores activation ids that are not in its store (once annotations are loaded) and closes its own thread with a local clear that does not notify the host.PopupV2renders nothing when the active annotation has no messages, instead of a bare composer.Deep links still work: activation that arrives before annotations load is stored as before. Single-annotator behavior is unchanged.
Test plan