Animate selected-file dependency links in the 3D view - #101
Open
braedonsaunders wants to merge 3 commits into
Open
Animate selected-file dependency links in the 3D view#101braedonsaunders wants to merge 3 commits into
braedonsaunders wants to merge 3 commits into
Conversation
Bring 3D force-graph edges to parity with the 2D Code particles: travelling beads only on the selected file's incoming/outgoing links, same orange/purple direction colors, and no motion when nothing is selected or reduced-motion is on. Co-authored-by: Braedon Saunders <braedonsaunders@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Match the Code-view particle stroke so travelling beads stay visible on the already-colored outgoing/incoming edges. Co-authored-by: Braedon Saunders <braedonsaunders@users.noreply.github.com>
White WebGL spheres disappear against the 3D background. Use the same outgoing/incoming stroke colors as the 2D path so direction stays obvious. Co-authored-by: Braedon Saunders <braedonsaunders@users.noreply.github.com>
braedonsaunders
marked this pull request as ready for review
September 4, 2026 01:03
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3D graph was the last link view without the active-file motion that landed for Code view (the leftover “later” item from the closed #82 discussion). Selecting a file in 3D now lights up its dependency edges with travelling particles and the same outgoing/incoming colors the 2D path already uses. Idle links stay still.
What changed
graph3dLinkParticles, which reusesforceLinkVisual/forceLinkRoleso 2D and 3D cannot drift on selection, direction, or reduced-motion.3d-force-graph’s own directional-particle API (linkDirectionalParticles, speed, width, color) instead of hand-rolled meshes.prefers-reduced-motion: reducealso yields 0.graph3dLinkWidth). Selection, thickness, and reduced-motion changes reapply the 3D accessors viaapplyLinkThickness; leaving the view still tears down the instance.vizUsesForceLinkParticles('graph3d')stays false. That helper is the SVG/CSS particle layer (Code view only). 3D uses the library API.How to see it
Tests
npm testis green (214). Extendedtests/code-canvas.test.mjsandtests/graph3d-config.test.mjsfor:Left out
force-link-particlepath on 3D (wrong renderer).Diff scope
index.htmlandtests/only.