Skip to content

ci: allow model dispatch bot in Claude action - #1300

Merged
Erin McNulty (erin2722) merged 1 commit into
mainfrom
erin/allow-model-dispatch-bot
Sep 24, 2026
Merged

Erin McNulty (erin2722) merged 1 commit into
mainfrom
erin/allow-model-dispatch-bot

Conversation

@erin2722

Copy link
Copy Markdown
Contributor

Summary

  • allow braintrust-bot to invoke the Claude Code step in the add-model workflow
  • retain the action's default rejection for every other bot

Why

Repository-dispatch runs are initiated by the Braintrust GitHub App, so Claude Code correctly identifies the actor as a bot and rejects it unless that specific bot is allowlisted.

Security

This names only braintrust-bot; it does not use the action's * wildcard. The workflow still accepts only the add-model repository-dispatch event and validates the provider and model slug before this step.

Verification

  • confirmed allowed_bots against the pinned Claude Code action's action.yml
  • workflow YAML parsed successfully
  • repository pre-commit hooks passed

@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ai-proxy Ready Ready Preview Sep 24, 2026 8:33pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T20:35:49.468380Z 86fa50b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86fa50b154

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

with:
anthropic_api_key: ${{ secrets.BRAINTRUST_AGENT_SPEND_API_KEY }}
github_token: ${{ github.token }}
allowed_bots: braintrust-bot

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allowlist the GitHub App's full bot login

When the repository dispatch is created by the Braintrust GitHub App, github.actor is braintrust-bot[bot], while the pinned Claude action compares allowed_bots against the actor's full login. Consequently, braintrust-bot does not match and the Claude step remains rejected for every dispatch that reaches this fallback; use braintrust-bot[bot] instead.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erin2722
Erin McNulty (erin2722) merged commit 1c537b8 into main Sep 24, 2026
8 checks passed

This branch was successfully deployed

1 active deployment
Preview — 86fa50b1 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants