Repository navigation
fix: use HTTP/1.1 for plaintext API endpoints - #200
Open
Andrew Kent (realark) wants to merge 1 commit into
Open
Andrew Kent (realark) wants to merge 1 commit into
Andrew Kent (realark) wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Generated Description
Context
Some HTTP servers close connections when Java's HTTP client requests an
h2cupgrade instead of falling back to HTTP/1.1. This broke the simple OpenTelemetry example against the local backend withHTTP/1.1 header parser received no bytes.Change
Use HTTP/1.1 for
http://API URLs. Leave HTTPS HTTP/2 negotiation and the configured SSL context unchanged. This works independently of the backend fix in https://github.com/braintrustdata/braintrust/pull/25654.Verification
BraintrustOpenApiClientTesttests passed withVCR_MODE=off. New coverage exercises a server that disconnects upgrade requests and verifies actual HTTP/2 negotiation over HTTPS../gradlew examples:simple-open-telemetry:runnow completes successfully against the existing local backend../gradlew checkwas not run.