Repository navigation
fix(devserver): resolve scorer parents from the request state - #1113
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
Conversation
> 🤖 **This text was AI-generated.** UI-selected remote eval scorers run with request-specific state, but parent resolution still looked up the active span in the global state: ```python span = current_span() ``` Allow current_span to accept an optional state and pass the request state through parent resolution so scorer invocations receive their scorer span: ```python span = current_span(state=state) ``` Keep existing no-argument calls and experiment/logger fallbacks unchanged. The live staging reproduction still needs to be rerun. Refs: SDK-815
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI-selected remote eval scorers run with request-specific state, but parent resolution still looked up the active span in the global state:
Allow current_span to accept an optional state and pass the request state through parent resolution so scorer invocations receive their scorer span:
Keep existing no-argument calls and experiment/logger fallbacks unchanged. The live staging reproduction still needs to be rerun.
Refs: SDK-815