fix: handle empty suffix in removesuffix

src/browserbase/_utils/_utils.py

@@ -370,7 +370,7 @@ def removesuffix(string: str, suffix: str) -> str:
 
     Backport of `str.removesuffix` for Python < 3.9
     """
-    if string.endswith(suffix):
+    if suffix and string.endswith(suffix):
         return string[: -len(suffix)]
     return string
 

tests/test_utils/test_utils.py

@@ -0,0 +1,31 @@
+from __future__ import annotations
+
+import pytest
+
+from browserbase._utils import removeprefix, removesuffix
+
+
+@pytest.mark.parametrize(
+    ("string", "prefix"),
+    [
+        ("browserbase", "browser"),
+        ("browserbase", "base"),
+        ("browserbase", ""),
+        ("", ""),
+    ],
+)
+def test_removeprefix_matches_stdlib(string: str, prefix: str) -> None:
+    assert removeprefix(string, prefix) == string.removeprefix(prefix)
+
+
+@pytest.mark.parametrize(
+    ("string", "suffix"),
+    [
+        ("browserbase", "base"),
+        ("browserbase", "browser"),
+        ("browserbase", ""),
+        ("", ""),
+    ],
+)
+def test_removesuffix_matches_stdlib(string: str, suffix: str) -> None:
+    assert removesuffix(string, suffix) == string.removesuffix(suffix)