fix(rerun): send project-relative spec paths to remote on re-run [SDK-7124] - #1173
Open
anish353 wants to merge 1 commit into
Open
fix(rerun): send project-relative spec paths to remote on re-run [SDK-7124]#1173anish353 wants to merge 1 commit into
anish353 wants to merge 1 commit into
Conversation
…-7124]
BROWSERSTACK_RERUN_TESTS arrives as bare filenames ("a.ts,b.ts").
run_settings is forwarded to the BrowserStack machines verbatim, where a
bare filename does not resolve against the project root, so Cypress exits
having run no spec at all ("Cypress could not run any of the specs").
getNumberOfSpecFiles already resolves those entries against
cypressProjectDir via matchBase globbing, but only persisted the resolved
list back to run_settings.specs under turboScaleSession. Persist it for
re-run sessions too, so the remote receives paths it can resolve.
Scoped to re-runs via a new shared predicate isReRunSpecsSession(), which
setUserSpecs now uses as well so the two call sites cannot drift. A plain
--spec glob is deliberately left untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1157 on the same ticket. That PR made the CLI select the right specs on a TRA "re-run failed tests"; this one makes the remote machines actually run them.
BROWSERSTACK_RERUN_TESTSarrives as bare filenames ("FO-E2E-02.ts, FO-E2E-05.ts").run_settingsis forwarded to the BrowserStack machines verbatim (capabilityHelper.js→obj.run_settings = JSON.stringify(bsConfig.run_settings)), and a bare filename does not resolve against the project root there — so Cypress exits having run no spec at all:getNumberOfSpecFilesalready resolves those entries againstcypressProjectDir(it globs withmatchBase: true, which is why the machine count is correct), but it only persisted the resolved list back torun_settings.specsunderturboScaleSession. For a normal run the remote kept receiving the unresolvable basenames.What lands here
bin/helpers/utils.jsisReRunSpecsSession()— the 3-part observability re-run predicate, now shared bysetUserSpecsandgetNumberOfSpecFilesso the two cannot drift apart.getNumberOfSpecFilespersists the already-resolved, project-relative paths torun_settings.specson a re-run.test/unit/bin/helpers/utils.jsspecsuntouched.Scoped deliberately: this is an
else ifon the re-run predicate, not a blanket write-back. A plain--specglob (e.g.cypress/tests/FlightOffer/*) is still forwarded verbatim rather than being expanded into an explicit file list.Verification
Reproduced and verified on real BrowserStack builds with a 5-spec suite (3 passing / 2 failing), using the customer's command shape (
--sync --spec "cypress/tests/FlightOffer/*"):BROWSERSTACK_RERUN_TESTS0519457f…75c45973…1e9ce9bf…,a6b73ce4…f5440dfc…Total tests: 2e0786caf…Runs 3/5 → Run 7 is the broken→fixed transition on identical input.
Test plan
getNumberOfSpecFiles— re-run path rewrites to project-relative paths; non-re-run path unchanged.test/unit/bin/helpers/utils.jssuite: 393 passing on this branch vs 391 on a cleanmastercheckout. The 5 failing (setLocalArgs/setNodeVersion/getVideoConfig×3) are pre-existing and unrelated — present on cleanmastertoo (verified viagit stash).--specglob is preserved verbatim and still matches all 9 specs; a run with no--specstill yieldsspecs: null.Notes / scope
/, matching the existing TurboScale branch.browserstack/github-actions/setup-env(v1.0.2+) with agithub-tokeninput — GitHub's native re-run API cannot inject env vars. That is a workflow/docs gap tracked separately on the ticket.Release
Release notes: Fixed BrowserStack "re-run failed tests" on Cypress running the full suite or failing with "could not run any of the specs" — the failed-spec list is now resolved to project-relative paths before it is sent to the BrowserStack machines.
Fixes SDK-7124.