fix(loadtesting): scrub 'protocol' from plu descriptions so the agent shows 'API' - #451
Merged
sourabhd-cbu merged 1 commit intoSep 28, 2026
Conversation
… shows 'API' #449 changed the user-facing testType LABEL to 'API', but left the internal glosses that pair plu with 'protocol' — e.g. 'plu = protocol/API load' and 'plu (protocol / API load)'. The agent reads those and renders the option back to the user as 'API/Protocol', defeating the label change. Replace every plu-associated 'protocol' mention with 'API' (6 spots) so nothing pairs plu with 'protocol' anywhere the model can echo. Text-only; returns/schemas unchanged.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited) Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #449 changed the user-facing testType label for
pluto 'API', the agent was still presenting it to users as "API/Protocol". Root cause: #449 deliberately kept the internal descriptions that pairpluwith the word protocol — and the model reads those and renders "API/Protocol" back, defeating the label change. There is no literal "API / Protocol" string left in any index; the leak comes from these glosses.Six residual mentions, all now changed to "API":
testTypedescplu = protocol/API loadplu = API load (server-side, non-browser)plu (protocol / API load)plu (API load)A protocol (plu) run is billed…An API (plu) run is billed……10x a protocol (plu) run……10x an API (plu) run…PLU (protocol) frameworks…PLU (API) frameworks…one PLU (protocol) leg…one PLU (API) leg…After this,
grep -i protocol capability/loadtesting.capability-index.jsonreturns 0.Scope / safety
returns, no schemas, no params touched.check-contractunbacked count unchanged vs base (21/75 — that clears to 0 once fix(loadtesting): back every capability's returns with a typed response schema #450 lands; unrelated to this PR).Note on why you may still see it in your client
This targets
feat/capability-registry. The running MCP reads the hosted per-env (prod/reg) registry, and #449's label change hasn't been propagated to those deploy branches yet — so both this scrub and #449 need to reach the prod/reg index before the change shows up in the client.