Skip to content

ci: fix broken /beta/ docs site and stale root logo - #403

Merged
btravers merged 1 commit into
mainfrom
fix/docs-beta-base-and-brand
Aug 27, 2026
Merged

ci: fix broken /beta/ docs site and stale root logo#403
btravers merged 1 commit into
mainfrom
fix/docs-beta-base-and-brand

Conversation

@btravers

@btravers btravers commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Two independent problems with the versioned docs deploy.

1. /beta/ is broken

https://btravstack.github.io/temporal-contract/beta/ returns 200 but renders blank.

Turbo 2.x strict env mode drops any variable a task does not declare in env. @temporal-contract/docs#build declared none, so DOCS_BASE never reached the VitePress config — the beta site built with the root base. Confirmed against the live deploy:

/beta/index.html → href="/temporal-contract/assets/style.Bp59bOjG.css"  → 404
                   (the file actually lives at /temporal-contract/beta/assets/…)

Every asset 404s, hence the blank page. DOCS_VERSIONS was dropped for the same reason, so neither site ever showed the version dropdown.

Fix: declare both in turbo.json. Verified locally — the built HTML now emits /temporal-contract/beta/assets/… and the dropdown renders.

2. The root site serves the old logo

The root is built from the latest stable tag, @temporal-contract/contract@7.0.0 (2026-07-11), which predates the rebrand commit c66c2d2 (2026-07-16). Working as the versioning scheme intends, just stale on the page most visitors land on.

Fix: overlay main's docs/public/ onto the stable worktree before building. Checked that every asset the tag references (logo*.svg, icons/*, og-*.png) exists in main's public/ under the same names, so the overlay cannot break the tag's build.

Not covered

The root site still ships v7 content and the v7 @btravstack/theme; only brand assets follow main. Making the whole landing page current means shipping 8.0.0 stable or dropping the versioned split — out of scope here.

No changeset: build/CI config only, nothing published changes.

Summary by CodeRabbit

  • Bug Fixes
    • Updated stable documentation builds to use the latest branding assets from the main documentation site.
    • Improved documentation build configuration to recognize documentation base and version settings.

Turbo 2.x strict env mode drops any variable a task does not declare, so
DOCS_BASE and DOCS_VERSIONS never reached VitePress. The beta site built
with the root base: /temporal-contract/beta/ served HTML pointing at
/temporal-contract/assets/*, which 404s, rendering a blank page. The
version dropdown was missing on both sites for the same reason.

The root site is built from the latest stable tag (7.0.0, 2026-07-11),
which predates the rebrand, so it serves the old logo. Overlay main's
docs/public/ onto the stable worktree before building — every asset the
tag references still exists there.
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: be8d1abb-def8-4b93-a494-16e6dc175b2b

📥 Commits

Reviewing files that changed from the base of the PR and between a2d7514 and 4a17c64.

📒 Files selected for processing (2)
  • .github/workflows/deploy-docs.yml
  • turbo.json

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The versioned documentation workflow now uses current docs/public assets from main. The Turbo build configuration permits DOCS_BASE and DOCS_VERSIONS.

Changes

Documentation build

Layer / File(s) Summary
Versioned documentation build wiring
.github/workflows/deploy-docs.yml, turbo.json
The stable build replaces tagged public assets with assets from main. The docs build allows DOCS_BASE and DOCS_VERSIONS as environment variables.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 4a17c

This change fixes versioned documentation asset paths and refreshes the root site's branding assets without changing published package behavior; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both primary changes: fixing the broken /beta/ documentation site and updating the stale root logo during CI deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docs-beta-base-and-brand

Comment @coderabbitai help to get the list of available commands.

@btravers
btravers merged commit 63325fc into main Aug 27, 2026
13 checks passed
@btravers
btravers deleted the fix/docs-beta-base-and-brand branch August 27, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant