ci: fix broken /beta/ docs site and stale root logo - #403
Conversation
Turbo 2.x strict env mode drops any variable a task does not declare, so DOCS_BASE and DOCS_VERSIONS never reached VitePress. The beta site built with the root base: /temporal-contract/beta/ served HTML pointing at /temporal-contract/assets/*, which 404s, rendering a blank page. The version dropdown was missing on both sites for the same reason. The root site is built from the latest stable tag (7.0.0, 2026-07-11), which predates the rebrand, so it serves the old logo. Overlay main's docs/public/ onto the stable worktree before building — every asset the tag references still exists there.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe versioned documentation workflow now uses current ChangesDocumentation build
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change fixes versioned documentation asset paths and refreshes the root site's branding assets without changing published package behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Two independent problems with the versioned docs deploy.
1.
/beta/is brokenhttps://btravstack.github.io/temporal-contract/beta/ returns 200 but renders blank.
Turbo 2.x strict env mode drops any variable a task does not declare in
env.@temporal-contract/docs#builddeclared none, soDOCS_BASEnever reached the VitePress config — the beta site built with the root base. Confirmed against the live deploy:Every asset 404s, hence the blank page.
DOCS_VERSIONSwas dropped for the same reason, so neither site ever showed the version dropdown.Fix: declare both in
turbo.json. Verified locally — the built HTML now emits/temporal-contract/beta/assets/…and the dropdown renders.2. The root site serves the old logo
The root is built from the latest stable tag,
@temporal-contract/contract@7.0.0(2026-07-11), which predates the rebrand commit c66c2d2 (2026-07-16). Working as the versioning scheme intends, just stale on the page most visitors land on.Fix: overlay main's
docs/public/onto the stable worktree before building. Checked that every asset the tag references (logo*.svg,icons/*,og-*.png) exists in main'spublic/under the same names, so the overlay cannot break the tag's build.Not covered
The root site still ships v7 content and the v7
@btravstack/theme; only brand assets follow main. Making the whole landing page current means shipping 8.0.0 stable or dropping the versioned split — out of scope here.No changeset: build/CI config only, nothing published changes.
Summary by CodeRabbit