Support buf.validate.oneof for Valid Types#1372
Open
macalinao wants to merge 1 commit intobufbuild:mainfrom
Open
Support buf.validate.oneof for Valid Types#1372macalinao wants to merge 1 commit intobufbuild:mainfrom
macalinao wants to merge 1 commit intobufbuild:mainfrom
Conversation
When `(buf.validate.oneof).required = true` is set on a oneof, the
generated Valid type now excludes the `{ case: undefined; value?: undefined }`
variant from the discriminated union, ensuring TypeScript enforces that
a case is always set.
Closes bufbuild#1171
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(buf.validate.oneof).required = trueis set on a oneof, the generated Valid type now excludes the{ case: undefined; value?: undefined }variant from the discriminated unionisProtovalidateOneofRequired()helper and updatedmessageNeedsCustomValidType()to detect required oneofsCloses #1171
Test plan
VTypes3message testing a message with only a required oneof (no required fields)