Repository navigation
Bug 1851435: Document test suites and add selenium/webservices options to run-tests-in-docker.sh - #188
Merged
Conversation
…s to run-tests-in-docker.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1851435
The Selenium and webservice suites were not reachable through
docker/run-tests-in-docker.sh. The script hardcodedTEST_NAMEtotest_bmoortest_sanity, so the only way to runqa/twas a directdocker compose runagainst the test stack. Documenting a single entrypoint meant making one exist, so this adds the two missing options
alongside the docs.
docker/run-tests-in-docker.sh
selenium) and 8 (webservices), mapping to theexisting
cmd_test_seleniumandcmd_test_webservicesinscripts/entrypoint.pl.docker-compose.test-mysql.yml, which already provides theselenium/standalone-firefoxservice the QA suites need.DEFAULT_TEST_ARGS=(), because those two entrypoint commandstake no file arguments and would otherwise inherit the
t/bmo/*.tdefault.
No change to the existing options and no change to
ci.yml. The browsersuite takes roughly 30 minutes, which is too slow for a merge gate, so it
stays available through the container only.
docker/README.md
Adds a "Running the Test Suites" section covering the option table, the
Selenium service and its configuration, how the QA suites are driven
through
scripts/entrypoint.pl, and two known failures: the accountcreation tests that are being reworked by the login/email separation
work, and an intermittent assertion in
test_edit_products_properties.t.Notes
shellcheck -xis clean.use
bash docker/run-tests-in-docker.sh. I can add the mode bit in aseparate commit if you would rather it be directly invocable.
generate_test_data.plcurrently aborts during test dataloading with a duplicate Priority value, which stops the QA suites
before any test runs. I am still isolating whether that is local state
or a regression, and will report it on its own bug rather than folding
it in here.